feat: implement ability to search when selecting datasets - #153

Adds a reusable searchable dataset selector across visualization blocks and map layers.

Changes:

• Introduces and exports DatasetSelector.
• Replaces existing dataset controls.
• Updates dependencies and adds a changeset.

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

• Files reviewed: 15/16 changed files
• Comments generated: 3
• Review effort level: Lite

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

Suppressed comments (11)

packages/commons/src/DatasetSelector.jsx:9

• This selector is only wired into map/BlockEdit; grouped-bars/BlockEdit.js and data-paragraph/BlockEdit.js still render the old SelectControl for Superset datasets, so users of those blocks still cannot search. Please update those dataset controls as part of this feature or narrow the feature scope.

export const DatasetSelector = (props) => {
    const {
        setAttributes,
        setState,
        loadMetadata,

packages/commons/src/index.js:45

• The new selector is not wired into all existing Superset dataset pickers: data-paragraph/BlockEdit.js:198-205 and grouped-bars/BlockEdit.js:353-365 still render SelectControl, so those blocks cannot search datasets. Please migrate those call sites as well, or narrow the feature scope in the PR description.

export { DatasetSelector } from './DatasetSelector';

plugins/wp-react-blocks-plugin/blocks/big-filter/BlockEdit.js:169

• datasets always contains the Select Dataset sentinel, so this length check is never zero while the API request is pending. Consequently the new combobox never shows its loading state; check the raw this.state.datasets (or an explicit loading flag) instead.

                                        isLoading={datasets.length === 0}

plugins/wp-react-blocks-plugin/blocks/big-number-trend/BlockEdit.js:162

• datasets always contains the Select Dataset sentinel, so this length check is never zero while the API request is pending. Consequently the new combobox never shows its loading state; check the raw this.state.datasets (or an explicit loading flag) instead.

                                        isLoading={datasets.length === 0}

plugins/wp-react-blocks-plugin/blocks/big-number/BlockEdit.js:144

• datasets always contains the Select Dataset sentinel, so this length check is never zero while the API request is pending. Consequently the new combobox never shows its loading state; check the raw this.state.datasets (or an explicit loading flag) instead.

                                        isLoading={datasets.length === 0}

plugins/wp-react-blocks-plugin/blocks/charts/BlockEdit.js:421

• datasets always contains the Select Dataset sentinel, so this length check is never zero while the API request is pending. Consequently the new combobox never shows its loading state; check the raw this.state.datasets (or an explicit loading flag) instead.

                                            isLoading={datasets.length === 0}

plugins/wp-react-blocks-plugin/blocks/d3Map/layers/Data.jsx:314

• This layer also prepends a Select Dataset option, so allDatasets.length === 0 is never true and the combobox cannot indicate that metadata is still loading. Pass an explicit loading state from the metadata owner instead of deriving it from this placeholder-inclusive list.

                            isLoading={allDatasets.length === 0}

plugins/wp-react-blocks-plugin/blocks/d3Map/layers/Flow.jsx:294

• This layer also prepends a Select Dataset option, so allDatasets.length === 0 is never true and the combobox cannot indicate that metadata is still loading. Pass an explicit loading state from the metadata owner instead of deriving it from this placeholder-inclusive list.

                        isLoading={allDatasets.length === 0}

plugins/wp-react-blocks-plugin/blocks/d3Map/layers/LatLong.jsx:255

• This layer also prepends a Select Dataset option, so allDatasets.length === 0 is never true and the combobox cannot indicate that metadata is still loading. Pass an explicit loading state from the metadata owner instead of deriving it from this placeholder-inclusive list.

                        isLoading={allDatasets.length === 0}

plugins/wp-react-blocks-plugin/blocks/filter/BlockEdit.js:260

• datasets always contains the Select Dataset sentinel, so this length check is never zero while the API request is pending. Consequently the new combobox never shows its loading state; check the raw this.state.datasets (or an explicit loading flag) instead.

                                    isLoading={datasets.length === 0}

plugins/wp-react-blocks-plugin/blocks/map/BlockEdit.js:12

• ComboboxControl is imported here but the file now renders the shared DatasetSelector instead, so this named import is unused and will fail the repository's lint rules. Remove it from the import list.

  ComboboxControl,

• Files reviewed: 14/15 changed files
• Comments generated: 4
• Review effort level: Lite